This repository was archived by the owner on Apr 18, 2025. It is now read-only.
NW6 | Orlando_Morales | JS3_Module | BookLibrary | Week1#275
Open
OrlandoMoralesKuan wants to merge 1 commit intoCodeYourFuture:mainfrom
Open
NW6 | Orlando_Morales | JS3_Module | BookLibrary | Week1#275OrlandoMoralesKuan wants to merge 1 commit intoCodeYourFuture:mainfrom
OrlandoMoralesKuan wants to merge 1 commit intoCodeYourFuture:mainfrom
Conversation
|
pseudopilot
suggested changes
May 17, 2024
Contributor
pseudopilot
left a comment
pseudopilot
left a comment
There was a problem hiding this comment.
@OrlandoMoralesKuan , great job!
It seems to me you only missed one thing in JS file.
But, please, also check inputs in index.html. Do you think all input types are correct?
| @@ -37,8 +37,8 @@ function submit() { | |||
| alert("Please fill all fields!"); | |||
Contributor
There was a problem hiding this comment.
It seems to me we're missing Author validation 🤔
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.